[coreboot-gerrit] [M] Change in coreboot[master]: security/tpm: make log format configurable via Kconfig

[Michał Żygowski (Code Review)]

Attention is currently required from: Tarun Tuli, Maciej Pijanowski, Jason Nien, Subrata Banik, Christian Walter, Kapil Porwal, Tim Wawrzynczak, Nick Vaccaro, Julius Werner, Krystian Hebel, Martin Roth, Sergii Dmytruk.

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68746 )

Change subject: security/tpm: make log format configurable via Kconfig
......................................................................

Patch Set 7:

(1 comment)

File src/security/tpm/tspi/crtm.h:

https://review.coreboot.org/c/coreboot/+/68746/comment/2a96f484_b44ae830 
PS7, Line 19: #if CONFIG(TPM_LOG_CB) && CONFIG(TPM1)
            : #  define TPM_MEASURE_ALGO VB2_HASH_SHA1
            : #elif CONFIG(TPM_LOG_CB) && CONFIG(TPM2)
            : #  define TPM_MEASURE_ALGO VB2_HASH_SHA256
            : #endif
            : 
            : #if !defined(TPM_MEASURE_ALGO)
            : #  if !CONFIG(TPM_MEASURED_BOOT)
            : #    define TPM_MEASURE_ALGO VB2_HASH_INVALID
            : #  else
            : #    error "Misconfiguration: failed to determine TPM hashing algorithm"
            : #  endif
            : #endif
Lets' make sure to get rid of the TPM_MEASURE_ALGO in subsequent patches, as this should not be needed. We should read the supported algorithms/enabled PCR banks from TPM and populate all possible hashes.