Attention is currently required from: David Wu, Krishna P Bhat D, Reka Norman, Reka Norman, Stefan Reinauer, Subrata Banik.
Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81928?usp=email )
Change subject: util/ifdtool: Add support for checking GPR0 status ......................................................................
Patch Set 11:
(3 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/81928/comment/7b7cb57a_c1313100 : PS8, Line 14: Done.
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/81928/comment/50496ac2_c6e0d404 : PS7, Line 1799: reg
nit: maybe rename this to something like `expected` to make it clearer.
Done. Rename it to `enabled_gprd`. Thanks.
https://review.coreboot.org/c/coreboot/+/81928/comment/6ff58eba_5104dca6 : PS7, Line 1801: : uint32_t gpr0_range_start, gpr0_range_end; : : if (calculate_gpr0_range(image, size, &gpr0_range_start, &gpr0_range_end)) : exit(EXIT_FAILURE); : : reg.data.start = (gpr0_range_start >> 12) & 0x7fff; : reg.data.end = (gpr0_range_end >> 12) & 0x7fff; : reg.data.read_protect_en = 0; : reg.data.write_protect_en = 1; :
Can you factor this out into a helper function like get_enabled_gprd(), and use it both here and in […]
Done. Please help to review, thanks!