Attention is currently required from: David Wu, Krishna P Bhat D, Reka Norman, Reka Norman, Stefan Reinauer, Subrata Banik.
3 comments:
Commit Message:
Done.
File util/ifdtool/ifdtool.c:
nit: maybe rename this to something like `expected` to make it clearer.
Done. Rename it to `enabled_gprd`.
Thanks.
uint32_t gpr0_range_start, gpr0_range_end;
if (calculate_gpr0_range(image, size, &gpr0_range_start, &gpr0_range_end))
exit(EXIT_FAILURE);
reg.data.start = (gpr0_range_start >> 12) & 0x7fff;
reg.data.end = (gpr0_range_end >> 12) & 0x7fff;
reg.data.read_protect_en = 0;
reg.data.write_protect_en = 1;
Can you factor this out into a helper function like get_enabled_gprd(), and use it both here and in […]
Done. Please help to review, thanks!
To view, visit change 81928. To unsubscribe, or for help writing mail filters, visit settings.