29 Aug
2019
29 Aug
'19
9:15 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34988 )
Change subject: mediatek/mt8183: Implement the dramc init setting ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/dra... PS2, Line 104: clrsetbits_le32(&ch[0].ao.shu[0].impcal1, (0x1f << 4) | (0x1f << 11) ,
space prohibited before that ',' (ctx:WxE)
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/34988
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I756ad37e78cd1384ee0eb97e5e18c5461d73bc7b
Gerrit-Change-Number: 34988
Gerrit-PatchSet: 8
Gerrit-Owner: huayang duan huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: SJ Huang sj.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: huayang duan huayangduan@gmail.com
Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 29 Aug 2019 07:15:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org
Gerrit-MessageType: comment