Attention is currently required from: Kyösti Mälkki.
Iru Cai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55289 )
Change subject: sb,soc/intel: Set IOAPIC redirection entry count
......................................................................
Patch Set 12:
(1 comment)
File src/arch/x86/ioapic.c:
https://review.coreboot.org/c/coreboot/+/55289/comment/3edcc86f_605eb7a4
PS12, Line 60: 0xff
Should this be 0xff or 0xffff?
Oh, I see ``count`` is a u8, so it's 0xff.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55289
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8da869ba390dd821b43032e4ccbc9291c39e6bab
Gerrit-Change-Number: 55289
Gerrit-PatchSet: 12
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Iru Cai
mytbk920423@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 23 Oct 2021 14:12:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Iru Cai
mytbk920423@gmail.com
Gerrit-MessageType: comment