Attention is currently required from: Felix Held, Felix Singer, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/77736?usp=email )
Change subject: soc/amd/common/block: Remove space after a cast
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/block/xhci/elog.c:
https://review.coreboot.org/c/coreboot/+/77736/comment/429ac322_cdd52f28?usp... :
PS2, Line 106: (const struct resource *)&res_store[i_slot].resources[0]
Same as in CB:77732. Maybe: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77736?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icccfbc535e005648e45156fc6810210d0ec86a98
Gerrit-Change-Number: 77736
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 10 Jan 2025 09:20:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de