Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31374 )
Change subject: superio/fintek: Add code for superio f81803a ......................................................................
Patch Set 2:
Patch Set 2:
please have a look at my two comments here https://review.coreboot.org/c/coreboot/+/21032/9/src/superio/fintek/f81803a/... I didn't review this version of the patch yet, since it's still marked as WIP.
John's code is the base of my code, and this code is board specific at the moment. When I started, his code allowed only enabling serial port and programming the port (not the IRQ). I did not touch his code, as a cursory inspection revealed that it should work (not tested yet). Instead, I concentrated on fan control, as padmelon fans are controlled by this SIO. I have a board with AMI BIOS on it, and verified that it does not program fan control, instead it relies on strapping to set both fans at 40% at power on (and the speed never changes). There was no CPU temperature reading (TSI), only temperature from external sensor. Voltages were being measured (though I did not check accuracy), as well as fan speed. All of that enabled by default, with almost no programming (I did found about 4 registers with values that were not power on default).
As I do have experience controlling fans using SIO HWM (work at Intel), I decided this would be a useful addition to the code. I could have added other functionality, but it did not look useful under coreboot context.
I have not yet tested the code (awaiting information on SIO connector for programming, which seems to be absent), reason why it's marked as WIP.