[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/nissa/var/rull: add ssd timeing and modify ssd GPIO pins of...

[Rui Zhou (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.

Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/84997?usp=email )

Change subject: mb/google/nissa/var/rull: add ssd timeing and modify ssd GPIO pins of rtd3
......................................................................

Patch Set 17:

(2 comments)

This change is ready for review.

File src/mainboard/google/brya/variants/rull/gpio.c:

https://review.coreboot.org/c/coreboot/+/84997/comment/73946876_e965c920?usp... :
PS13, Line 31: 	PAD_CFG_GPO(GPP_B11, 1, DEEP),
> why you are touching WLAN PIN in this CL ?

Done

https://review.coreboot.org/c/coreboot/+/84997/comment/c00e1dac_cf470108?usp... :
PS13, Line 142:
> why empty line ?

Done