Attention is currently required from: CK HU, Yu-Ping Wu. Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44713 )
Change subject: soc/mediatek/mt8192: Add dramc ac timing setting ......................................................................
Patch Set 50:
(4 comments)
File src/soc/mediatek/mt8192/dramc_pi_main.c:
https://review.coreboot.org/c/coreboot/+/44713/comment/600dc323_8650abf3 PS41, Line 42: ptRFCab_Opt
How about we add a comment? […]
use ptr_trfcab_opt.
https://review.coreboot.org/c/coreboot/+/44713/comment/2ba30d78_05dc1944 PS41, Line 43: tRFCab_Opt
Follow jesd spec, we'd prefer to use this style for clear name.
use trfcab_opt.
File src/soc/mediatek/mt8192/dramc_pi_main.c:
https://review.coreboot.org/c/coreboot/+/44713/comment/15f62720_68e8912d PS48, Line 173: SET32_BITFIELDS(&ch[chn].ao.shu_ac_time_05t, SHU_AC_TIME_05T_TRFC_05T, : trfc_05t);
Format it like this: […]
Ack
https://review.coreboot.org/c/coreboot/+/44713/comment/b7860d0b_84bdbb77 PS48, Line 177: SET32_BITFIELDS(&ch[chn].ao.shu_ac_time_05t, SHU_AC_TIME_05T_TRFCPB_05T, : trfrc_pb05t);
Same
Ack