Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Christian Walter, Lean Sheng Tan, Maximilian Brune, Naresh Solanki.
David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79086?usp=email )
Change subject: mainboard/emulation/qemu-sbsa: Add qemu-sbsa board
......................................................................
Patch Set 6:
(3 comments)
File src/mainboard/emulation/qemu-sbsa/dsdt.asl:
PS3:
Some parts of this file are indented with tabs, and others with spaces. […]
Done
https://review.coreboot.org/c/coreboot/+/79086/comment/f49b8530_7129cfee :
PS3, Line 14: Method (_SRS, 1) { } \
Looks like this device is meant to be non-configurable (OSPM can't change the IRQ number), as _SRS d […]
Done
https://review.coreboot.org/c/coreboot/+/79086/comment/72482c20_221897ed :
PS3, Line 103: Device (PRT1) {
Since you've used macros for other things, how about using another macro for the USB ports?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79086?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iacc9aaf065e0d153336cbef9a9b5b46a9eb24a53
Gerrit-Change-Number: 79086
Gerrit-PatchSet: 6
Gerrit-Owner: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Comment-Date: Wed, 29 Nov 2023 02:44:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment