Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34646 )
Change subject: smbios: Make SMBIOS type 3 enclosure type settable at runtime
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34646/2/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/34646/2/src/arch/x86/smbios.c@a623
PS2, Line 623:
We have a mainboard that will be used in different enclosures and we are planning on using a single […]
Mat, You might put this information in the commit message to explain why its needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34646
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba6e582640989f5cb7e6613813e7b033760a977c
Gerrit-Change-Number: 34646
Gerrit-PatchSet: 2
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lance Zhao
lance.zhao@gmail.com
Gerrit-Comment-Date: Thu, 01 Aug 2019 21:01:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Comment-In-Reply-To: Lance Zhao
lance.zhao@gmail.com
Gerrit-MessageType: comment