Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44772 )
Change subject: mb/prodrive/hermes/hda_verb: Fix some issues ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/44772/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44772/2//COMMIT_MSG@10 PS2, Line 10: ACL888
ALC888
Done
https://review.coreboot.org/c/coreboot/+/44772/2/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/44772/2/src/mainboard/prodrive/herm... PS2, Line 31: COMBINATION,
This can be 1/8" mono/stereo. line in on rear will be removed.
Done
https://review.coreboot.org/c/coreboot/+/44772/2/src/mainboard/prodrive/herm... PS2, Line 75: INTEGRATED,
this should be JACK, EXTERNAL_PRIMARY_CHASSIS, FRONT, MIC_IN, PINK
Done
https://review.coreboot.org/c/coreboot/+/44772/2/src/mainboard/prodrive/herm... PS2, Line 93: false,
shouldn't this be true?
It's not connected to SENSE_A or SENSE_B.
https://review.coreboot.org/c/coreboot/+/44772/2/src/mainboard/prodrive/herm... PS2, Line 128: SEPARATE_CHASSIS,
internal was correct here
Done
https://review.coreboot.org/c/coreboot/+/44772/2/src/mainboard/prodrive/herm... PS2, Line 140: SEPARATE_CHASSIS,
internal was correct here too
Done