[coreboot-gerrit] [S] Change in coreboot[main]: drivers/intel/fsp: Work around multi-socket Xeon-SP pipe init bug

[Jérémy Compostella (Code Review)]

Attention is currently required from: Arthur Heymans.

Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80579?usp=email )

Change subject: drivers/intel/fsp: Work around multi-socket Xeon-SP pipe init bug
......................................................................

Patch Set 7:

(1 comment)

File src/drivers/intel/fsp2_0/memory_init.c:

https://review.coreboot.org/c/coreboot/+/80579/comment/f6423ddd_461130aa :
PS7, Line 174: & CONFIG(FSP_SPEC_VIOLATION_XEON_SP_HEAP_WORKAROUND)) {
             : 		extern char _fspm_heap[];
             : 		extern char _efspm_heap[];
Shouldn't they be declared in `src/include/symbols.h` ? At the very minimum I suggest that you use the `DECLARE_REGION` macro.