Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Patrick Rudolph.
Sergii Dmytruk has posted comments on this change by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/82639?usp=email )
Change subject: mb/qemu-{i440fx,q35}: reduce default ROM size to 8M
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82639/comment/10d31365_ef3559aa?usp... :
PS1, Line 9: QEMU doesn't allow to use bigger images with '-drive if=pflash', which
No idea why, I guess this was a design decision made by QEMU. […]
After facing this error recently I found a failed attempt to increase the size in https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg04146.html, wanted to link to modern version of that code now and found https://gitlab.com/qemu-project/qemu/-/commit/0657c657eb37bb48bfd9fe3ae8a323.... There seems to be `max-fw-size` machine option for more than 3 years, which is present in `qemu-system-x86_64 -M q35,help` output but search at https://www.qemu.org/docs/master/index.html doesn't find it.
The default is still 8 MiB though, so this change still improves usability.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82639?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If36cb754a8e75e23bce49ff568dd88e5db279bb8
Gerrit-Change-Number: 82639
Gerrit-PatchSet: 2
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Thu, 30 May 2024 18:10:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com