Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42134 )
Change subject: src/include: Add PnP/HWM unset_and_set functions
......................................................................
Patch Set 11: Code-Review+1
I like this and it does solve an existing problem. I'd drop the and between unset and set, since the _and adds 4 chars, but not much information. unset_set does sound a bit weird though. only giving a +1 for now to see if someone else might come up with better idea; if not I'd +2 this; probably either with or without the _and dropped
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42134
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica01211af2a9a00aed98880844a836f6b7957b14
Gerrit-Change-Number: 42134
Gerrit-PatchSet: 11
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 20 Aug 2020 11:29:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment