Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33114 )
Change subject: Makefile.inc: Fix compilation issue with !CONFIG_ENABLE_STAGE_RAMSTAGE
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/33114/5/src/cpu/x86/Makefile.inc
File src/cpu/x86/Makefile.inc:
https://review.coreboot.org/#/c/33114/5/src/cpu/x86/Makefile.inc@20
PS5, Line 20: ifeq ($(CONFIG_STAGE_RAMSTAGE),y)
But where are these rules being acted upon? e.g. if nothing is referencing sipi. […]
I'm getting below error when i'm skip guarding
make: *** No rule to make target 'build/rmodules_/cpu/x86/sipi_vector.o', needed by 'build/cpu/x86/sipi_vector.o'. Stop.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33114
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6ad9b43dde2d2af40a7b2bc1773c0338ae9552b
Gerrit-Change-Number: 33114
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Jun 2019 14:51:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment