Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25208 )
Change subject: sdm845: Add QCLib to RomStage to perform IP init ......................................................................
Patch Set 76:
(5 comments)
LGTM after fixing the size_t/ssize_t thing.
https://review.coreboot.org/#/c/25208/76/src/mainboard/google/cheza/chromeos... File src/mainboard/google/cheza/chromeos.fmd:
https://review.coreboot.org/#/c/25208/76/src/mainboard/google/cheza/chromeos... PS76, Line 27: ( nit: flags are normally written without space before the parenthesis (compare COREBOOT(CBFS) above).
https://review.coreboot.org/#/c/25208/76/src/soc/qualcomm/sdm845/include/soc... File src/soc/qualcomm/sdm845/include/soc/memlayout.ld:
https://review.coreboot.org/#/c/25208/76/src/soc/qualcomm/sdm845/include/soc... PS76, Line 31: 8192 nit: 8K
https://review.coreboot.org/#/c/25208/69/src/soc/qualcomm/sdm845/include/soc... File src/soc/qualcomm/sdm845/include/soc/qclib.h:
https://review.coreboot.org/#/c/25208/69/src/soc/qualcomm/sdm845/include/soc... PS69, Line 52: #define QCLIB_GA_ENABLE_UART_LOGGING 0x00000001
OK, we will keep deprecated in list moving forward. […]
Yeah, it doesn't really matter, it just makes it easier for me because I don't always get the new QcLib releases as soon as you do. (Which reminds me, I'm still on r38... any chance we could unblock the next one now?)
https://review.coreboot.org/#/c/25208/76/src/soc/qualcomm/sdm845/qclib.c File src/soc/qualcomm/sdm845/qclib.c:
https://review.coreboot.org/#/c/25208/76/src/soc/qualcomm/sdm845/qclib.c@43 PS76, Line 43: if (size < 0) This must be a different variable that's ssize_t.
https://review.coreboot.org/#/c/25208/69/src/soc/qualcomm/sdm845/qclib_execu... File src/soc/qualcomm/sdm845/qclib_execute.c:
https://review.coreboot.org/#/c/25208/69/src/soc/qualcomm/sdm845/qclib_execu... PS69, Line 1: /*
I think I addressed all of the earlier comments when I created the common/ patch. […]
Yes, I think it's all good now, thanks.