Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35239 )
Change subject: hatch: automate creating a new variant in coreboot
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc...
File util/mainboard/google/hatch/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc...
PS13, Line 54: # Start a branch. Use YMD timestamp to avoid collisions.
: DATE=$(date +%Y%m%d)
: repo start "create_${variant}_${DATE}"
Get rid of this? This is just a personal preference, right? […]
The goal is to have the scripts do all of the basic work to clone a baseboard into a new variant's name. I would prefer to keep a branch for this, so I'll change it over to git instead of repo.
https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc...
File util/mainboard/google/hatch/dptf.asl.tmpl:
https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc...
PS13, Line 4: * Copyright __YEAR__ Google LLC
Yes, I think so.
OK, will do.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35239
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a5b9c8735faafebb2e4e384cb3346867d64c556
Gerrit-Change-Number: 35239
Gerrit-PatchSet: 14
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Scott Collyer
scollyer@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan
quasisec@google.com
Gerrit-Comment-Date: Mon, 09 Sep 2019 19:57:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment