Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42134 )
Change subject: src/include: Add PnP/HWM unset_and_set functions
......................................................................
Patch Set 11:
Patch Set 8:
(2 comments)
Please start a discussion about the naming convention on the mailing
list. We already have `clrsetbits` and `pci_update_config` (with
different semantics, I know). It doesn't feel right to add a third
nomenclature during a review that is less visible to most of the
community.
https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/BULIH...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42134
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica01211af2a9a00aed98880844a836f6b7957b14
Gerrit-Change-Number: 42134
Gerrit-PatchSet: 11
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 20 Aug 2020 09:12:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment