Yongqiang Niu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31478 )
Change subject: mediatek/mt8183: Add display driver
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/31478/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31478/2//COMMIT_MSG@8
PS2, Line 8:
What datasheet did you use?
does datasheet means hardware register map?
https://review.coreboot.org/#/c/31478/2//COMMIT_MSG@9
PS2, Line 9: BUG=b:80501386
Also add b:117254947
add this bug id in patch3
https://review.coreboot.org/#/c/31478/2/src/mainboard/google/kukui/mainboard...
File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/31478/2/src/mainboard/google/kukui/mainboard...
PS2, Line 66: start
Starting
modified in patch3
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31478
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4aecc58d081f14f5d136b9ff8e813e6f40f78eb
Gerrit-Change-Number: 31478
Gerrit-PatchSet: 3
Gerrit-Owner: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yongqiang Niu
yongqiang.niu@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Wed, 20 Feb 2019 07:12:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: You-Cheng Syu
youcheng@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment