Attention is currently required from: Tim Wawrzynczak, EricR Lai.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48785 )
Change subject: mb/google: Convert some CONFIG(CHROMEOS) preprocessor
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Actually there was not much conversion of preprocessor here, I had this on hold for other reasons.
I could only find cbmem_add() with CBMEM_ID_WIFI_CALIBRATION. So presumably something in the OS then uses the CBMEM data? But the structs in vpd_calibration.c are not __packed nor do they appear under commonlib/ headers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48785
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica8691e3dc4feecbeb11ba3f5868932f926965b2
Gerrit-Change-Number: 48785
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 04 Feb 2021 05:14:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment