[coreboot-gerrit] Change in ...coreboot[master]: mb/lenovo/x131e: function key support

[James (Code Review)]

James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31067 )

Change subject: mb/lenovo/x131e: function key support
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/31067/1/src/ec/lenovo/h8/Kconfig 
File src/ec/lenovo/h8/Kconfig:

https://review.coreboot.org/#/c/31067/1/src/ec/lenovo/h8/Kconfig@35 
PS1, Line 35: 	  Use alternative EC query methods for X131e
> why is it called EC query methods ??

The methods being modified (_Qxx) are handlers for EC queries.

https://review.coreboot.org/#/c/31067/1/src/ec/lenovo/h8/acpi/ec.asl 
File src/ec/lenovo/h8/acpi/ec.asl:

https://review.coreboot.org/#/c/31067/1/src/ec/lenovo/h8/acpi/ec.asl@a141 
PS1, Line 141:
> I'd prefer to split Method(_Q*  into a new file and include those depending on the real ec in use.

Would the _Qxx methods that are common between standard H8 and H8-compatible IT8518 be duplicated between the files in this case?