[coreboot-gerrit] Change in coreboot[master]: cpu: Add microcode at pre-defined address

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38640 )

Change subject: cpu: Add microcode at pre-defined address
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38640/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38640/6//COMMIT_MSG@7 
PS6, Line 7: c
> I'm aware that it's not possible to give the microcode location to FSP-T during runtime. […]

ah, now I understand what you meant. Sorry for being so tone-deaf. I believe it may be a good approach (having assembly code load ucode).  I do not think it is really necessary to load ucode specifically with assembly before CAR is set up. I'd guess the only reason why would want to do it is that microcode fix is required for CAR to function properly.

Anyway, for now we have to use FSP-T but like I said we are planning on changing that.

Arthur I am marking this comment as 'resolved', please let me know if you have objections.

https://review.coreboot.org/c/coreboot/+/38640/6//COMMIT_MSG@13 
PS6, Line 13: 
            : Also, on current version of FSP-T on Xeons microcode is not optional.
> I think we all agree we need less blobs not more. […]

marking this as "resolved"