4 Jun
2019
4 Jun
'19
6:31 a.m.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33172 )
Change subject: siemens/mc_apl5: Add own GPIO table ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33172/3/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl5/gpio.c:
https://review.coreboot.org/#/c/33172/3/src/mainboard/siemens/mc_apl1/varian... PS3, Line 203: Remove the reset signal for the PCIe switch. Maybe: "Disable reset for PCIe switch."
https://review.coreboot.org/#/c/33172/3/src/mainboard/siemens/mc_apl1/varian... PS3, Line 408: Hold PCIe switch in reset. Maybe: "Enable reset for PCIe switch."
--
To view, visit https://review.coreboot.org/c/coreboot/+/33172
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3424cb0b867c5d43cd7db9e9ae654196cef5e90
Gerrit-Change-Number: 33172
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 04 Jun 2019 04:31:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment