build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42859 )
Change subject: amdfwtool: Take a config file instead of command line parameters ......................................................................
Patch Set 31:
(6 comments)
https://review.coreboot.org/c/coreboot/+/42859/31/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/42859/31/util/amdfwtool/amdfwtool.c... PS31, Line 1455: if ((config_handle = fopen(config, "r")) == NULL) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42859/31/util/amdfwtool/data_parse.... File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/42859/31/util/amdfwtool/data_parse.... PS31, Line 225: psp_tableptr ++; space prohibited before that '++' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/42859/31/util/amdfwtool/data_parse.... PS31, Line 275: bhd_tableptr ++; space prohibited before that '++' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/42859/31/util/amdfwtool/data_parse.... PS31, Line 282: int get_input_file_line(FILE * f, char line[], int line_buf_size) "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/42859/31/util/amdfwtool/data_parse.... PS31, Line 294: printf("The line size in config file should be lower than %d bytes.\n", MAX_LINE_SIZE); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/31/util/amdfwtool/data_parse.... PS31, Line 295: exit (1); space prohibited between function name and open parenthesis '('