Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36685 )
Change subject: src/mb/intel/coffeelake_rvp: Add mainboard for CML-S RVP8
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36685/13/src/mainboard/intel/coffee...
File src/mainboard/intel/coffeelake_rvp/variants/cml_s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36685/13/src/mainboard/intel/coffee...
PS13, Line 89: register "PcieRpEnable[4]" = "1"
Yes, it is x4.
Sorry if I wasn't clear. My question is, if a PCIe root port is configured as X4, aren't the next three root port devices automatically disabled? That means only PcieRpEnable[4] would be necessary.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf723ada53dc441cb9fabc8efb1dcd3da8e0991c
Gerrit-Change-Number: 36685
Gerrit-PatchSet: 14
Gerrit-Owner: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 01 Apr 2020 23:15:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Gaggery Tsai
gaggery.tsai@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment