[coreboot-gerrit] Change in coreboot[master]: soc/intel/{adl, common}: Add routines into CSE IA-common code

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Subrata Banik, Angel Pons, Nick Vaccaro, Werner Zeh, Patrick Rudolph, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61518 )

Change subject: soc/intel/{adl, common}: Add routines into CSE IA-common code
......................................................................

Patch Set 1:

(2 comments)

Patchset:

PS1: 
Hmm, I'd rather not have SoC code that calls into a weak function in common code which then just calls back into SoC code... why add the proverbial middleman?

File src/soc/intel/alderlake/finalize.c:

https://review.coreboot.org/c/coreboot/+/61518/comment/ff400799_bab61465 
PS1, Line 83: /* Function to set D0I3 for all HECI devices */
            : void soc_set_d0i3_for_heci(void)
            : {
            : 	unsigned int cse_dev[] = {
            : 		PCH_DEVFN_CSE,
            : 		PCH_DEVFN_CSE_2,
            : 		PCH_DEVFN_CSE_3,
            : 		PCH_DEVFN_CSE_4
            : 	};
            : 
            : 	for (int i = 0; i < ARRAY_SIZE(cse_dev); i++) {
            : 		if (!is_cse_devfn_visible(cse_dev[i]))
            : 			continue;
            : 
            : 		set_cse_device_state(cse_dev[i], DEV_IDLE);
            : 	}
            : }
            : 
Could this function just be moved to common code?