Attention is currently required from: Jérémy Compostella, Martin L Roth, Shuo Liu.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86941?usp=email )
Change subject: cpu/x86/mtrr: Exclude ranges above 4G if temporary MTRRs exhausted ......................................................................
Patch Set 3:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86941/comment/8d7984c3_0ae733d8?usp... : PS2, Line 11: >
more than
Done
https://review.coreboot.org/c/coreboot/+/86941/comment/78eb607f_4385a1cf?usp... : PS2, Line 12: MB
GiB
Done
https://review.coreboot.org/c/coreboot/+/86941/comment/30ccc69c_c12f0a77?usp... : PS2, Line 17: max available, retry with `above4gb` set to 0.
maximum
Done
File src/cpu/x86/mtrr/mtrr.c:
https://review.coreboot.org/c/coreboot/+/86941/comment/466dbb11_96301f7d?usp... : PS2, Line 663: static int calc_var_mtrrs(struct memranges *addr_space, : int above4gb, int address_bits, int *num_mtrrs_used)
I would suggest to reflow.
Done
https://review.coreboot.org/c/coreboot/+/86941/comment/fd5f59df_98e59f32?usp... : PS2, Line 664: int
size_t
what's the rationale here? changing this to a size_t would require changing wb_deftype_count and uc_deftype_count as well, to a larger type for a value that won't exceed 16. I could see changing it to a uint8_t bute not a size_t
https://review.coreboot.org/c/coreboot/+/86941/comment/00ff900e_6f4f733c?usp... : PS2, Line 664: int
this will be a somewhat extensive change, I'll do it in a separate patch and rebase this one top
Done
https://review.coreboot.org/c/coreboot/+/86941/comment/2922f769_7c780799?usp... : PS2, Line 893: sol.mtrr_default_type = calc_var_mtrrs(&addr_space, above4gb, address_bits, &num_mtrrs_used);
sure, I can rework it to skip `prepare_var_mtrrs` altogether since we know it will fail, and just pr […]
Done