Attention is currently required from: Matt DeVillier.
Sean Rhodes has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86321?usp=email )
Change subject: ec/starlabs/merlin: Drop unused reference to events.asl
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
how are those in scope?
`src/ec/starlabs/merlin/Makefile.mk`:
```
EC_VARIANT_DIR := $(call strip_quotes, $(CONFIG_EC_VARIANT_DIR))
CPPFLAGS_common += -I$(src)/ec/starlabs/merlin/variants/$(EC_VARIANT_DIR)
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86321?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifbb986378dd49c6a1d316a4922c46c46180497ee
Gerrit-Change-Number: 86321
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Sun, 09 Feb 2025 20:17:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com