Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41081 )
Change subject: soc/intel/cannonlake: Add VrPowerDeliveryDesign to chip options
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41081/3/src/soc/intel/cannonlake/fs...
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/41081/3/src/soc/intel/cannonlake/fs...
PS3, Line 464: VrPowerDeliveryDesign
maybe it's better to keep the default and only overwrite it when config->VrPowerDeliveryDesign != 0
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41081
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89b8dceb40fa6a9dc67b218e91bf728ff928b5a0
Gerrit-Change-Number: 41081
Gerrit-PatchSet: 4
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 14 May 2020 07:48:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment