Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32642 )
Change subject: soc/amd/stoneyridge: Rename AcpiMmio blocks ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32642/1/src/soc/amd/stoneyridge/include/soc/... File src/soc/amd/stoneyridge/include/soc/iomap.h:
https://review.coreboot.org/#/c/32642/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 37: ACPIMMIO_SM_PCI_BASE
I can understand the name deriving from AMD_SB_ACPI_MMIO_ADDR, but I still believe that just MMIO... […]
With the naming convention, I sort of agree except that it's been named AcpiMmio for ten years. I wanted each individual block named similarly, so it's ACPIMMIO...BASE.
I don't know if you were tying to make a comment about this particular block you highlighed. +000 is an alternate method for accession the PCI config space IIRC.