Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33448 )
Change subject: mb/google/octopus: rename get_board_sku and make it overridable
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33448/1/src/mainboard/google/octopus/mainboa...
File src/mainboard/google/octopus/mainboard.c:
https://review.coreboot.org/#/c/33448/1/src/mainboard/google/octopus/mainboa...
PS1, Line 121: __weak
It is not clear to me why this is weak. All you need is this to be exposed globally (non static). […]
Hi Aaron,
to have weak attribute was just in case it might need to override in variants. (ex reef case)
that's why rename this function name as well because of it might be invoked by variants.
thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33448
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fb7b5eeac48f2cd9c24fa1d3ac3fe4b390762d2
Gerrit-Change-Number: 33448
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quantatw.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 17 Jun 2019 02:29:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment