[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Fix ACPI exception AE_NOT_FOUND

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35621 )

Change subject: soc/intel/skylake: Fix ACPI exception AE_NOT_FOUND
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35621/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35621/2//COMMIT_MSG@11 
PS2, Line 11: Fixes ACPI exception: AE_NOT_FOUND
> It was generating an ACPI path for devices behind PCI bridges (with devfn 0), that of course couldn't be resolved.
> Now it returns NULL, doesn't generate an ACPI path, which is correct, as the SSDT gen returns.

Could you please add this information to the commit description as it provides more context to the change and the original failure?

https://review.coreboot.org/c/coreboot/+/35621/2/src/soc/intel/skylake/acpi.... 
File src/soc/intel/skylake/acpi.c:

https://review.coreboot.org/c/coreboot/+/35621/2/src/soc/intel/skylake/acpi.... 
PS2, Line 763: 	if (dev->bus && dev->bus->secondary > 0)
Please add a comment here indicating the purpose of the check.