Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36847 )
Change subject: [WIP] security/vboot: Remove selected_region from struct vboot_working_data ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36847/1/src/security/vboot/bootmode... File src/security/vboot/bootmode.c:
https://review.coreboot.org/c/coreboot/+/36847/1/src/security/vboot/bootmode... PS1, Line 27: vboot_get_recovery_reason_shared_data We should also start thinking about how to clean up this recovery_reason business. Why do we need to independently read the recovery reason stored in nvdata and the one from vb2_shared_data? After introducing persistent context, can we just rely on the latter?
What kind of API do we want to use to expose recovery_reason from vboot? Do we need a vb2api_get_recovery_reason()? And a vb2api_clear_recovery_reason()?