[coreboot-gerrit] Change in coreboot[master]: AGESA f15tn: Drop `IDSOPT_ASSERT_ENABLED`

[Angel Pons (Code Review)]

Attention is currently required from: Arthur Heymans, Alexander Couzens, Kyösti Mälkki, Patrick Rudolph.
Hello build bot (Jenkins), Arthur Heymans, Alexander Couzens, Kyösti Mälkki, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/53983

to look at the new patch set (#2).

Change subject: AGESA f15tn: Drop `IDSOPT_ASSERT_ENABLED`
......................................................................

AGESA f15tn: Drop `IDSOPT_ASSERT_ENABLED`

The `ASSERT` macro is already defined in `src/include/assert.h`, and
AGESA's definition is never used. On Asus A88XM-E, toggling the value of
the `IDSOPT_ASSERT_ENABLED` macro does not change the resulting binary
when using reproducible builds. Attempting to use AGESA's definition of
the `ASSERT` macro results in build errors:

In file included from src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c:56:
 src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c: In function 'GetType4Type7Info':
 src/vendorcode/amd/agesa/f15tn/Include/Ids.h:371:33: error: statement with no effect [-Werror=unused-value]
      #define ASSERT(conditional) ((conditional) ? 0 : IdsAssert (STOP_CODE));

Given that coreboot's definition of `ASSERT` is more useful, drop
AGESA's broken definition and the useless `IDSOPT_ASSERT_ENABLED` macro.
Also remove the `IdsAssert` function, as it is no longer used anywhere.

Tested with BUILD_TIMELESS=1, Asus A88XM-E remains identical.

Change-Id: Ia4e5dbfd3d2e5cec979b8b16fbc11d1ca8a0661e
Signed-off-by: Angel Pons 
---
M src/mainboard/amd/parmer/OptionsIds.h
M src/mainboard/amd/thatcher/OptionsIds.h
M src/mainboard/asus/a88xm-e/OptionsIds.h
M src/mainboard/asus/f2a85-m/OptionsIds.h
M src/mainboard/hp/pavilion_m6_1035dx/OptionsIds.h
M src/mainboard/lenovo/g505s/OptionsIds.h
M src/mainboard/msi/ms7721/OptionsIds.h
M src/vendorcode/amd/agesa/f15tn/Include/Ids.h
M src/vendorcode/amd/agesa/f15tn/MainPage.h
M src/vendorcode/amd/agesa/f15tn/Proc/IDS/Debug/IdsDebug.c
10 files changed, 0 insertions(+), 94 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/53983/2