Hello Matt Delco,
I'd like you to do a code review. Please visit
https://review.coreboot.org/28334
to review the following change.
Change subject: eve: Specify an unique ID for PS2 devices ......................................................................
eve: Specify an unique ID for PS2 devices
Windows certification tests will fail if the PS2 devices are using Plug and Play ID (PNP0303). For all Chromebooks we should use GOOG000A.
BRANCH=eve BUG=b:110066056 TEST=AltOS certification test verify.
Change-Id: I479471fdb3102e3b492612a4e6ad07612273083a Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Reviewed-on: https://chromium-review.googlesource.com/1098874 Reviewed-by: Matt Delco delco@chromium.org Reviewed-by: Hung-Te Lin hungte@chromium.org Commit-Queue: Hung-Te Lin hungte@chromium.org Trybot-Ready: Hung-Te Lin hungte@chromium.org --- M src/ec/google/chromeec/acpi/superio.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/28334/1
diff --git a/src/ec/google/chromeec/acpi/superio.asl b/src/ec/google/chromeec/acpi/superio.asl index 8faabee..6c9cb2c 100644 --- a/src/ec/google/chromeec/acpi/superio.asl +++ b/src/ec/google/chromeec/acpi/superio.asl @@ -137,8 +137,8 @@ { Name (_UID, 0) Name (_ADR, 0) - Name (_HID, EISAID("PNP0303")) - Name (_CID, EISAID("PNP030B")) + Name (_HID, "GOOG000A") + Name (_CID, Package() { EISAID("PNP0303"), EISAID("PNP030B") } )
Method (_STA, 0, NotSerialized) { Return (0x0F)