Attention is currently required from: Nico Huber, Tarun Tuli, Martin L Roth, Jérémy Compostella, Angel Pons, Arthur Heymans, Kyösti Mälkki, Andrey Petrov.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69757 )
Change subject: [RFC] Pull libgfxinit in early romstage ......................................................................
Patch Set 5:
(5 comments)
File src/arch/x86/car.ld:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164352): https://review.coreboot.org/c/coreboot/+/69757/comment/2f0f8cf0_166c4faa PS5, Line 72: * un-initialized variables which are initialized at runtime. Therefor, 'Therefor' may be misspelled - perhaps 'Therefore'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164352): https://review.coreboot.org/c/coreboot/+/69757/comment/283b4c1c_706ee9ab PS5, Line 73: * they can be be placed in the .bss section.*/ Possible repeated word: 'be'
File src/soc/intel/common/block/graphics/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164352): https://review.coreboot.org/c/coreboot/+/69757/comment/217e2551_e21e8101 PS5, Line 26: if (!CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164352): https://review.coreboot.org/c/coreboot/+/69757/comment/8247b7c8_c7a581b3 PS5, Line 26: if (!CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164352): https://review.coreboot.org/c/coreboot/+/69757/comment/25156208_5cff27af PS5, Line 26: if (!CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) please, no spaces at the start of a line