Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33115 )
Change subject: Makefile.inc: Compile smm files independent ARCH_RAMSTAGE_X86_32/64
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/33115/7/src/arch/x86/Makefile.inc
File src/arch/x86/Makefile.inc:
https://review.coreboot.org/#/c/33115/7/src/arch/x86/Makefile.inc@340
PS7, Line 340: smm-$(CONFIG_IDT_IN_EVERY_STAGE) += idt.S
i was only keeping root dependencies for now. […]
If you are building for smm you should pull in the same objects as before. I don't understand your reasoning here at all. It doesn't make sense -- just because your build options you don't care why would you make policy and semantic changes on other people's usages?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33115
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17a3eb80a4d5ef86e0319357c01b6bf5b90ef15b
Gerrit-Change-Number: 33115
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:24:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment
