Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59509 )
Change subject: soc/intel/common/thermal: Refactor thermal block to improve reusability ......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/block/thermal/Kconfig:
https://review.coreboot.org/c/coreboot/+/59509/comment/02bc521b_81aa1bca PS4, Line 7: config SOC_INTEL_COMMON_BLOCK_THERMAL_PCI_DEV : bool : default n : select SOC_INTEL_COMMON_BLOCK_THERMAL : help : This option allows to configure PCH thermal registers using Thermal PCI device : for chipsets till Ice Lake PCH. : : config SOC_INTEL_COMMON_BLOCK_THERMAL_BEHIND_PMC : bool : default n : select SOC_INTEL_COMMON_BLOCK_THERMAL : help : This option allows to configure PCH thermal registers using PMC PWRMBASE : for chipsets since Tiger Lake PCH.
Meh, looks like Kconfig doesn't like my idea... I'd simply use a preprocessor check inside `thermal. […]
HI Eric and Angel,
I have summarized my observation based on what happen when SoC user wrongly tries to select both the Kconfig(s).
With below results, I believe our latest patchset doesn't require any more modification to prohibit user to make redundant selection of thermal Kconfig.
Also, we have #error check in thermal.h to avoid unnecessary include of this header without proper Kconfig selection.
Please share your thoughts ?
For ADL:
When I have selected both the Kconfig as below: (ideally it should be SOC_INTEL_COMMON_BLOCK_THERMAL_BEHIND_PMC) select SOC_INTEL_COMMON_BLOCK_THERMAL_PCI_DEV select SOC_INTEL_COMMON_BLOCK_THERMAL_BEHIND_PMC
Error as below:
WARNING: unmet direct dependencies detected for SOC_INTEL_COMMON_BLOCK_THERMAL_BEHIND_PMC Depends on [n]: SOC_INTEL_COMMON [=y] && SOC_INTEL_COMMON_BLOCK [=y] && !SOC_INTEL_COMMON_BLOCK_THERMAL_PCI_DEV [=y] Selected by [y]: - CPU_SPECIFIC_OPTIONS [=y] && SOC_INTEL_ALDERLAKE [=y]
*** ERROR: 1 warnings encountered, and warnings are errors.
For CML:
When I have selected both the Kconfig as below: (ideally it should be SOC_INTEL_COMMON_BLOCK_THERMAL_PCI_DEV) select SOC_INTEL_COMMON_BLOCK_THERMAL_PCI_DEV select SOC_INTEL_COMMON_BLOCK_THERMAL_BEHIND_PMC
Error as below:
WARNING: unmet direct dependencies detected for SOC_INTEL_COMMON_BLOCK_THERMAL_BEHIND_PMC Depends on [n]: SOC_INTEL_COMMON [=y] && SOC_INTEL_COMMON_BLOCK [=y] && !SOC_INTEL_COMMON_BLOCK_THERMAL_PCI_DEV [=y] Selected by [y]: - CPU_SPECIFIC_OPTIONS [=y] && SOC_INTEL_CANNONLAKE_BASE [=y]
*** ERROR: 1 warnings encountered, and warnings are errors.