[coreboot-gerrit] [S] Change in coreboot[main]: soc/amd/cezanne: add option to disable I2S master clock output of FCH

[Anand Vaikar (Code Review)]

Attention is currently required from: Ana Carolina Cabral, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Nick Kochlowski.

Anand Vaikar has posted comments on this change by Anand Vaikar. ( https://review.coreboot.org/c/coreboot/+/85865?usp=email )

Change subject: soc/amd/cezanne: add option to disable I2S master clock output of FCH
......................................................................

Patch Set 4:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85865/comment/a158c5f1_b6d32c12?usp... :
PS3, Line 7: soc/amd/cezanne: Disable I2S internal clock based on mainboard config
> maybe: […]

Done

File src/soc/amd/cezanne/fch.c:

https://review.coreboot.org/c/coreboot/+/85865/comment/b5e700f4_7f68d0a1?usp... :
PS3, Line 86: const struct soc_amd_cezanne_config *cfg;
            : 	cfg = config_of_soc();
> i'd do the creation of the local variable and the assignment in one line: […]

Done

https://review.coreboot.org/c/coreboot/+/85865/comment/d33ef9a1_62e293f8?usp... :
PS3, Line 89: 	/* Master clock is dsabled as the clock is given externally*/
> i'd say that this line of comments is a bit redundant and could be dropped. […]

Done