Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35726 )
Change subject: drivers/aspeed/common: Add support for high resolution framebuffer ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35726/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35726/1//COMMIT_MSG@10 PS1, Line 10: Copy the linux kernel code and add a bunch of wrapper structs to make it : compile. : Convert the EDID to a drm_display_mode, which is understood by the : driver. Please format this as a list, if you list the changes.
https://review.coreboot.org/c/coreboot/+/35726/1//COMMIT_MSG@19 PS1, Line 19: woring working
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/ast2050/... File src/drivers/aspeed/ast2050/ast2050.c:
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/ast2050/... PS1, Line 37: Why the new blank line?
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/ast_i2c.c:
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/common/a... PS1, Line 1: Remove the blank line?
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/ast_mode.c:
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/common/a... PS1, Line 1: Remove blank line?