build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30934 )
Change subject: qualcomm/qcs405: enable SPI bus 4 for TPM ......................................................................
Patch Set 12:
(13 comments)
https://review.coreboot.org/#/c/30934/12/src/soc/qualcomm/qcs405/spi.c File src/soc/qualcomm/qcs405/spi.c:
https://review.coreboot.org/#/c/30934/12/src/soc/qualcomm/qcs405/spi.c@341 PS12, Line 341: gpio_configure(GPIO(37), 2, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); line over 80 characters
https://review.coreboot.org/#/c/30934/12/src/soc/qualcomm/qcs405/spi.c@341 PS12, Line 341: gpio_configure(GPIO(37), 2, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); code indent should use tabs where possible
https://review.coreboot.org/#/c/30934/12/src/soc/qualcomm/qcs405/spi.c@341 PS12, Line 341: gpio_configure(GPIO(37), 2, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); please, no spaces at the start of a line
https://review.coreboot.org/#/c/30934/12/src/soc/qualcomm/qcs405/spi.c@342 PS12, Line 342: gpio_configure(GPIO(38), 2, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); line over 80 characters
https://review.coreboot.org/#/c/30934/12/src/soc/qualcomm/qcs405/spi.c@342 PS12, Line 342: gpio_configure(GPIO(38), 2, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); code indent should use tabs where possible
https://review.coreboot.org/#/c/30934/12/src/soc/qualcomm/qcs405/spi.c@342 PS12, Line 342: gpio_configure(GPIO(38), 2, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); please, no spaces at the start of a line
https://review.coreboot.org/#/c/30934/12/src/soc/qualcomm/qcs405/spi.c@343 PS12, Line 343: gpio_configure(GPIO(117), 2, GPIO_PULL_UP, GPIO_16MA, GPIO_INPUT); line over 80 characters
https://review.coreboot.org/#/c/30934/12/src/soc/qualcomm/qcs405/spi.c@343 PS12, Line 343: gpio_configure(GPIO(117), 2, GPIO_PULL_UP, GPIO_16MA, GPIO_INPUT); code indent should use tabs where possible
https://review.coreboot.org/#/c/30934/12/src/soc/qualcomm/qcs405/spi.c@343 PS12, Line 343: gpio_configure(GPIO(117), 2, GPIO_PULL_UP, GPIO_16MA, GPIO_INPUT); please, no spaces at the start of a line
https://review.coreboot.org/#/c/30934/12/src/soc/qualcomm/qcs405/spi.c@344 PS12, Line 344: gpio_configure(GPIO(118), 2, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); line over 80 characters
https://review.coreboot.org/#/c/30934/12/src/soc/qualcomm/qcs405/spi.c@344 PS12, Line 344: gpio_configure(GPIO(118), 2, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); code indent should use tabs where possible
https://review.coreboot.org/#/c/30934/12/src/soc/qualcomm/qcs405/spi.c@344 PS12, Line 344: gpio_configure(GPIO(118), 2, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); please, no spaces at the start of a line
https://review.coreboot.org/#/c/30934/12/src/soc/qualcomm/qcs405/spi.c@345 PS12, Line 345: break; trailing whitespace