Attention is currently required from: Jon Murphy, Julius Werner, Kapil Porwal, Subrata Banik, Yu-Ping Wu.
Raul Rangel has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87031?usp=email )
Change subject: security/vboot: Add option for enabling ADB over network via GBB flag
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I didn't read the whole chain, but I'm working on trying to drop this GBB flag.
My goal is to keep ADB over network default enabled for fatcat AP FW serial image (which is often used for debugging purpose)
We can land a change to the fatcat OS configs to enable insecure ADB by default. You are still early on, and won't be dogfooding anytime soon, so there shouldn't be any push back.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87031?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb3a69f20ae39baf482a748a00556268d0d0aef7
Gerrit-Change-Number: 87031
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Konrad Adamczyk
konrada@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 02 Apr 2025 15:26:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org