Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34137 )
Change subject: soc/intel/common/lpss: Add function to check for a LPSS controller
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34137/7/src/soc/intel/common/block/...
File src/soc/intel/common/block/include/intelblocks/lpss.h:
https://review.coreboot.org/c/coreboot/+/34137/7/src/soc/intel/common/block/...
PS7, Line 45: controller
nit: controllers
Ok. Done
https://review.coreboot.org/c/coreboot/+/34137/6/src/soc/intel/common/block/...
File src/soc/intel/common/block/lpss/lpss.c:
https://review.coreboot.org/c/coreboot/+/34137/6/src/soc/intel/common/block/...
PS6, Line 103: if (dev->path.type != DEVICE_PATH_PCI)
- That's not part of this commit. […]
1. Ok updated the commit message to highlight the SOC expectations.
2/3. As updated in the commit msg, The strong API for the SOC list needs to come from SOC. Cannonlake already maintains that list. The SOC would ensure that all and valid LPSS controllers are provided through strong function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34137
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f5bb268fc581280bb1b87b6b175a0299a24a44a
Gerrit-Change-Number: 34137
Gerrit-PatchSet: 8
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Tue, 23 Jul 2019 13:57:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment