Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31313 )
Change subject: arch/arm: Make ARM stages select ARCH_ARM
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
This no longer does the thing the original patch tried to do? But LGTM anyway.
https://review.coreboot.org/c/coreboot/+/31313/6/src/arch/arm/armv4/Kconfig
File src/arch/arm/armv4/Kconfig:
https://review.coreboot.org/c/coreboot/+/31313/6/src/arch/arm/armv4/Kconfig@...
PS6, Line 2: bool
This is functionally equivalent, right? Any reason we're changing it? Personally, I find "def_bool n" more descriptive that having to know off-hand that the default default value is n.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31313
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ed4a71599641db606510e5304b9f0acf9b7eb88
Gerrit-Change-Number: 31313
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 15 Jul 2019 22:44:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment