Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40861 )
Change subject: mb/intel/tglrvp: Enable recovery in TGL RVP
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40861/5/src/mainboard/intel/tglrvp/...
File src/mainboard/intel/tglrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/40861/5/src/mainboard/intel/tglrvp/...
PS5, Line 23: select EC_GOOGLE_CHROMEEC_SWITCHES
this should be moved under config TGL_CHROME_EC.
With this change, TGL_INTEL_EC build is failed during make olddefconfig
ex)
make distclean
cp 3rdparty/blobs/files/configs/config.tglrvp_up3 .config
echo "CONFIG_TGL_INTEL_EC=y" >> .config
make olddefconfig
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40861
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e88200e3f8418e5b0ab39ac65ed1b3545ce111e
Gerrit-Change-Number: 40861
Gerrit-PatchSet: 5
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-Comment-Date: Thu, 04 Jun 2020 23:23:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment