Attention is currently required from: Ben Kao, Dinesh Gehlot, Dtrain Hsu, Intel coreboot Reviewers, Jamie Chen, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Jérémy Compostella has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/87033?usp=email )
Change subject: mb/var/uldrenite: Configure descriptor for either MBVR or FIVR
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/uldrenite/variant.c:
https://review.coreboot.org/c/coreboot/+/87033/comment/09bd2af8_eb312165?usp... :
PS6, Line 96: 0xc33, 0x72}
Any specification to reference?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87033?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I337574c8c55889ceb49b9f33625feadb48bd8890
Gerrit-Change-Number: 87033
Gerrit-PatchSet: 6
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Ben Kao
ben.kao@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Jamie Chen
jamie.chen@intel.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Ben Kao
ben.kao@intel.com
Gerrit-Comment-Date: Tue, 01 Apr 2025 16:45:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No