Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35080 )
Change subject: Documentation/acpi: Add new document on adding ACPI devices to devicetree ......................................................................
Patch Set 2:
(5 comments)
Thanks for doing this!
https://review.coreboot.org/c/coreboot/+/35080/2/Documentation/acpi/devicetr... File Documentation/acpi/devicetree.md:
https://review.coreboot.org/c/coreboot/+/35080/2/Documentation/acpi/devicetr... PS2, Line 10: of a "device tree" to expose devices to the OS. May as well make it explicit here that devicetree is used in coreboot to generate ACPI tables.
https://review.coreboot.org/c/coreboot/+/35080/2/Documentation/acpi/devicetr... PS2, Line 20: and may only have a devicetree.cb file. Or you can always just write the AML code What does AML stand for?
https://review.coreboot.org/c/coreboot/+/35080/2/Documentation/acpi/devicetr... PS2, Line 70: 0x15, trailing whitespace here.
https://review.coreboot.org/c/coreboot/+/35080/2/Documentation/acpi/devicetr... PS2, Line 92: ## Diving into the above example: You can move this header up a bit to capture the chip entry as well.
https://review.coreboot.org/c/coreboot/+/35080/2/Documentation/acpi/devicetr... PS2, Line 156: ### _S0W I think markdown style requires a blank line after a header. What is _S0W short for? that might help here.