Thanks for doing this!

View Change

5 comments:

• File Documentation/acpi/devicetree.md:

  • Patch Set #2, Line 10: of a "device tree" to expose devices to the OS.

    May as well make it explicit here that devicetree is used in coreboot to generate ACPI tables.

  • Patch Set #2, Line 20: and may only have a devicetree.cb file. Or you can always just write the AML code

    What does AML stand for?

  • Patch Set #2, Line 70: 0x15,

    trailing whitespace here.

  • Patch Set #2, Line 92: ## Diving into the above example:

    You can move this header up a bit to capture the chip entry as well.

  • Patch Set #2, Line 156: ### _S0W

    I think markdown style requires a blank line after a header.
    What is _S0W short for? that might help here.

To view, visit change 35080. To unsubscribe, or for help writing mail filters, visit settings.