Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46661 )
Change subject: sc7180: Add Modem region in memlayout to avoid modem cleanup in Secboot reboot. ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46661/1/src/soc/qualcomm/sc7180/car... File src/soc/qualcomm/sc7180/carve_out.c:
https://review.coreboot.org/c/coreboot/+/46661/1/src/soc/qualcomm/sc7180/car... PS1, Line 6: #define MODEM_ID_ADDR (void *)0x146ABC00 This should be declared as a 4-byte region in memlayout.ld instead.
https://review.coreboot.org/c/coreboot/+/46661/1/src/soc/qualcomm/sc7180/car... PS1, Line 9: #define MODEM_ID_WIFI_END (void *)0x88000000 Rather than declaring that here, let's split the memlayout region in two (e.g. REGION(dram_modem_wifi_only, 0x86000000, 32M, 4) and REGION(dram_modem_extra, 0x88000000, 108M, 4)). Then just use the bounds _dram_modem_wifi_only and _edram_modem_extra for the LTE case.